-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zh-cn translation #185
Conversation
…iew.md Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Summary: After reviewing all the individual summaries, the overall summary of the GitHub Pull Request titled "add zh-cn translation" is as follows: The pull request includes several translations from English to Simplified Chinese across different files in the documentation. While most of the changes seem correct and valuable, there are a few potential problems and errors that need to be addressed. Potential problems include a large number of file changes, lack of context or explanation for the changes, accuracy and consistency of translations, lack of tests for translated content, lack of review by a native Chinese speaker, inclusion of personal information in the patch, broken hyperlinks, duplication of sections, formatting issues, lack of context for changes to commands and sample prompts, and potential issues with the removal of the step to download the model file. The most important findings include accurate and comprehensive translation for the new file DetailsCommit 8c68af5f0241b4aa590de9966262d52e38ef287aKey Changes:
Potential Problems:
Overall, this pull request seems to be a straightforward translation from English to Simplified Chinese. The changes look correct and there are no obvious issues. Commit 8fd09b10657f8586317f799fed94f896b4ab29b1Key changes:
Potential problems:
Commit fca42f5ae0f026ab5f29c926619c77e0b265492bKey changes:
Potential problems:
Overall, the changes in this patch seem minor and should not introduce any major issues. Commit 9ee9f25ce09f61563b03c2d3115fd21667f012e5Key Changes:
Findings:
Potential Problems:
Suggestions:
Commit c2110dc6a58e0e0be6270f3fce95306ffc24e02dKey changes:
Potential problems:
Overall, the changes seem to be adding Chinese translation for the installation instructions in the Chinese documentation. There are a few minor issues that need to be addressed. Commit 78dc85bf393b2caaa17530007d22841483791ff5Key Changes:
Potential Problems:
Commit 1843de186478e25679714d43fc4f889972e34848Key changes:
Potential problems:
Overall, the patch seems to be a straightforward addition of a Chinese translation to the Commit 3b682dfc647622b3c4df2faa782f576bf68a3771Key changes:
Potential problems:
Commit f8e72fe494022230f2b1f23fba57db20ab246dd2Key Changes:
Potential Problems:
Commit 2873e6d1c5983ed5ecd09b910fb670cbd09835b4Key changes:
Potential problems:
Commit dc44b1134777c560c73ce13101ab2a68448cda92Key changes in the patch:
Potential problems:
Commit 62661bd59a1ac09770d6050020d98fcac2937759Key changes:
Potential problems:
Commit d1195b0277ba16220341adec9cb7e022ee6a6d6dKey Changes:
Potential Problems:
Overall, the patch successfully adds the missing links to the translated document. The changes look good and can be merged into the codebase. Commit c3d03789f7d31c1a5f636534d58bf2e5dc1aa587Key changes in the patch:
Potential problems:
Commit 18acb3ea4d63a40cdded9fcba2365cd4162e898bKey changes:
Potential problems:
Overall, this patch seems to be a simple translation update without any significant issues. Commit ad7597a39880879de04bb178adc909e34bc1a39bKey changes:
Potential problems:
Overall, the patch adds the Chinese translation to the specified files without any apparent issues. Commit 07fbf851a8899beb0c1986883d494cdd789b516bKey changes:
Potential problems:
Overall, more information and context are needed to fully assess the impact and quality of this patch. Commit 2ce027abe2574d9be70998fbd448f20d8a29ea94Key changes:
Potential problems:
Overall, this patch seems to be a straightforward translation of the content from English to Chinese (Simplified). No potential problems were identified. Commit 03ee4f694b87ad8d72428de780d154fb6c55c6b8Key changes:
Potential problems:
Commit fed1f5552173614ac81ee7a2bd0617283eacebb8Key Changes:
Potential Problems:
Overall, the changes seem to be straightforward translation updates for the Chinese version of the documentation. Commit a1af96ba8e4c9cfbdfe6dec348ba2a060ba3cc5dKey changes:
Potential problems:
Commit 39c77446c17f125780da50e0cd7d21068c807936Key changes:
Potential problems:
Commit 80f89dd108882deb5e546f240c5ea25a1f0834f4Key changes:
Potential problems:
|
Hi @ezirmusitua Thanks for your contribution. You really did a lot of work. It will take me some time to review your PR. Thank you very much! |
Signed-off-by: ezirmusitua <jferroal@gmail.com>
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/cli.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/wasmedge/integrations.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/aot.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/cli.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/docker_wasm.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/docker_wasm.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/docker_wasm.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/getting-started/quick_start.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/getting-started/quick_start.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/getting-started/quick_start.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/getting-started/quick_start_docker.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/getting-started/quick_start_docker.md
Outdated
Show resolved
Hide resolved
@ezirmusitua Please fix the DCO problem. |
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/cli.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/cli.md
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/build-and-run/cli.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/getting-started/quick_start_redhat.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/overview.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/usage/serverless/vercel.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/usage/serverless/vercel.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/usage/serverless/vercel.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/usage/serverless/vercel.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/wasmedge/features.md
Outdated
Show resolved
Hide resolved
…n_r1392653345 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392652961 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392647856 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392604553 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392650533 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392621661 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392632935 Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
Signed-off-by: alabulei1 <vivian.xiage@gmail.com> Signed-off-by: Michael Yuan <michael@secondstate.io>
Signed-off-by: alabulei1 <vivian.xiage@gmail.com> Signed-off-by: Michael Yuan <michael@secondstate.io>
…n_r1392653345 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392652961 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392647856 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392604553 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392650533 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392621661 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392632935 Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: Michael Yuan <michael@michaelyuan.com>
Signed-off-by: Michael Yuan <michael@michaelyuan.com>
…ew.md (WasmEdge#183) * translate i18n/zh/docusaurus-plugin-content-docs/current/start/ overview.md Signed-off-by: ezirmusitua <jferroal@gmail.com> * Update overview.md Signed-off-by: ezirmusitua <jferroal@gmail.com> --------- Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392653345 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392652961 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392647856 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392604553 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392650533 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392621661 Signed-off-by: ezirmusitua <jferroal@gmail.com>
…n_r1392632935 Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Hi @ezirmusitua Sorry for my late reply. Thank you! |
* translate i18n/zh/docusaurus-plugin-content-docs/current/start/ overview.md Signed-off-by: ezirmusitua <jferroal@gmail.com> * add zh-cn translation Signed-off-by: ezirmusitua <jferroal@gmail.com> * fix: repo references Signed-off-by: ezirmusitua <jferroal@gmail.com> * Signed-off-by: alabulei1 <vivian.xiage@gmail.com> * Update llm inference docs (WasmEdge#187) Signed-off-by: alabulei1 <vivian.xiage@gmail.com> * Update llm_inference.md Signed-off-by: alabulei1 <vivian.xiage@gmail.com> Signed-off-by: Michael Yuan <michael@secondstate.io> * Update llm_inference.md Signed-off-by: alabulei1 <vivian.xiage@gmail.com> Signed-off-by: Michael Yuan <michael@secondstate.io> * Update llm_inference.md Signed-off-by: Michael Yuan <michael@michaelyuan.com> * Update llm_inference.md Signed-off-by: Michael Yuan <michael@michaelyuan.com> * translate i18n/zh/docusaurus-plugin-content-docs/current/start/overview.md (WasmEdge#183) * translate i18n/zh/docusaurus-plugin-content-docs/current/start/ overview.md Signed-off-by: ezirmusitua <jferroal@gmail.com> * Update overview.md Signed-off-by: ezirmusitua <jferroal@gmail.com> --------- Signed-off-by: ezirmusitua <jferroal@gmail.com> * add missing links Signed-off-by: ezirmusitua <jferroal@gmail.com> * fix links in plugins(zh) Signed-off-by: ezirmusitua <jferroal@gmail.com> * add missing links Signed-off-by: ezirmusitua <jferroal@gmail.com> * doc: remove unnecessary space Signed-off-by: ezirmusitua <jferroal@gmail.com> * apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392653345 Signed-off-by: ezirmusitua <jferroal@gmail.com> * apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392652961 Signed-off-by: ezirmusitua <jferroal@gmail.com> * apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392647856 Signed-off-by: ezirmusitua <jferroal@gmail.com> * apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392604553 Signed-off-by: ezirmusitua <jferroal@gmail.com> * apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392650533 Signed-off-by: ezirmusitua <jferroal@gmail.com> * apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392621661 Signed-off-by: ezirmusitua <jferroal@gmail.com> * apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392632935 Signed-off-by: ezirmusitua <jferroal@gmail.com> * fix translations Signed-off-by: ezirmusitua <jferroal@gmail.com> * fix rebase Signed-off-by: ezirmusitua <jferroal@gmail.com> --------- Signed-off-by: ezirmusitua <jferroal@gmail.com> Signed-off-by: alabulei1 <vivian.xiage@gmail.com> Signed-off-by: Michael Yuan <michael@secondstate.io> Signed-off-by: Michael Yuan <michael@michaelyuan.com> Co-authored-by: alabulei1 <vivian.xiage@gmail.com> Co-authored-by: Michael Yuan <michael@michaelyuan.com> Signed-off-by: kelvin <pkelvin123456789@gmail.com>
Explanation
Add zh-cn translation
Related issue
N/A
What type of PR is this
Proposed Changes
Translate i18n/zh/docusaurus-plugin-content-docs/current/